Message: previous - next
Month: October 2012

Re: [trinity-devel] Sanity checks to the migratekde3 (commit 58823f36)

From: Darrell Anderson <humanreadable@...>
Date: Sun, 7 Oct 2012 13:01:20 -0700 (PDT)
> I have another suggestion for change. During the search in
> the profile is treated, they are not searched folders in kmail/mail. But
> the same is necessary for folders dimap, imap and also autosave. On the
> folder kmail/search I'm not sure. Proposed patch attached.

I have no problem with excluding imap folders but I can't test because I don't use imap.

> Next, I wanted to ask whether we can assume the presence of
> xargs on the users machines? It can in the replacement lower overhead of
> repeated execution sed and thus increase the speed. For example:
> find $HOME/.trinity \
>        -path $HOME/.trinity/share/apps/kmail/autosave -prune -o \
>        -path $HOME/.trinity/share/apps/kmail/dimap -prune -o \
>        -path $HOME/.trinity/share/apps/kmail/imap -prune -o \
>        -path $HOME/.trinity/share/apps/kmail/mail -prune -o \
>        -path $HOME/.trinity/share/apps/kmail/search -prune -o \
>        -type f -print0 | \
>   xargs -r0 sed -i "s|/opt/kde/|${TDEDIR}/|g"
> Instead of launching many sed, how much will be files, can
> be run only one sed, which will process all files that are found.
> What is your opinion on this?

If xargs on all systems is a safe presumption then I have no problem with that either. I should make more use of xargs in my own habits. Just lazy. :)

If your testing of the imap and xarg changes work on your system, I say go ahead and push the patch. I can test the xargs part here.