trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: October 2012

Re: [trinity-devel] CMakeLists.txt enhancement

From: Darrell Anderson <humanreadable@...>
Date: Mon, 29 Oct 2012 10:36:58 -0700 (PDT)
Suggested changes to tdebase:

setted concurantly -> set concurrently

if it is so, when WITH_SHADOW will have no effect -> WITH_PAM will override WITH_SHADOW

next options are also required -> then the following options are also required

> TDEHW is already in GIT. Anybody who builds from GIT can use that
> option. I use the option to build in Slackware 14.0, which
> no longer supports HAL.
> 
> hm... I see... Tim has used different inclusion guards for that and defined them only in
> config.h.cmake... what's why I haven't noticed them... it seems to be a temporary solution,
> isn't it?

Permanent. :) Not everybody is building and using packages from GIT for the simple reason that GIT is, technically, the development/experimental branch. Thus many people might not notice these changes. I have been using the GIT branch as my primary desktop environment for several months. Therefore I'm more intimate with these changes than most people using Trinity. :)

> I've added an «affections» but I can't handle the description now... cause I still don't
> understand how it works/what it uses etc.

Description: The TDEHW libs provide hardware detection formerly provided by HAL.

We are using bug report 850 to track TDEHW implementation.
 
> /thoughts aloud/ writing a documentation by a person who doesn't know english very well is not a
> really good idea...

I have been providing technical writing services for three decades. Thus, I have an eye to catch these things. :) I'm a tad lazy with my correspondence in this list, but for the official documentation I have high standards. So don't worry too much. I could make the changes myself and push to GIT but that would not provide you an opportunity to know what could or should be changed. I also don't believe I should make changes without your knowledge because that action would be construed as subversive and not courteous. :) My only goal is to ensure Trinity documentation is professional, not to be an anal ass about what you propose. ;) There are others in the project who do not speak/write English natively. I watch for that and try to help, just as I am doing here. Conversely, I don't speak/write other languages and I rely on them to ensure texts are translated correctly. :)

Adding the comments to the CMakeLists.txt files is a great idea. As long as we are patient with one another the patches will get pushed to GIT. :)

Darrell