Message: previous - next
Month: October 2012

Re: [trinity-devel] Latest GIT is broken

From: Darrell Anderson <humanreadable@...>
Date: Tue, 30 Oct 2012 12:19:52 -0700 (PDT)
> >> How do konqueror and kdialog store the bookmarks; i.e. what is the
> >> format >> of the files storing this information?
> >
> > konqueror stores bookmarks in xml format.
> > file ~/.trinity/share/apps/konqueror/bookmarks.xml
> > for kdialog, I have no clue (never used bookmarks with that).

> Very odd; changes to the moc should not be affecting XML file storage!

The problem was not that the xml files were being changed. The problem was the bookmarks stopped functioning. That is, selecting a bookmark from the list resulted in nothing happening. I don't pretend to understand all pieces, but the problem was something like the bookmarks were sending the link but the receiving snippet of code dumped the information to the infamous bit bucket. Or the pick list action was dumping the selection.

I don't know how the first round of TQ_PROPERTY/TQ_ENUMS patches caused this, but they did. As I mentioned in a previous mail, somewhere after that the bookmarks started functioning again, but then I experienced build failures with the weird "::" lines in the affected files. When I posted this morning I had forgotten that the bookmarks were again functioning, but there was a problem the day after the first wave of those patches.

> tdegames has been fixed in GIT hash 7b29b83.  This should provide a
> template for resolution of the other moc-related failures.  Note that the
> moc does output an error message early in the build process (before it
> spits out an empty .moc file); this message is usually sufficient to track
> down the exact failing header line.

Okay. To test I have to edit my build scripts to not reverse the patches. Because tqt3 is involved, I have to rebuild from scratch, so this will be a few hours until we know.