trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: November 2012

GNU make warnings

From: Darrell Anderson <humanreadable@...>
Date: Wed, 28 Nov 2012 09:35:04 -0800 (PST)
I see the following configure/make warnings with tdebindings:

configure.in:53: the top level
korundum/rubylib/rbkconfig_compiler/Makefile.am:5: `%'-style pattern rules are a GNU make extension
qtsharp/src/bindings/Makefile.am:6: wildcard *.cs: non-POSIX variable name
qtsharp/src/bindings/Makefile.am:6: (probably a GNU make extension)
qtsharp/src/bindings/Makefile.am:6: wildcard static/*.cs: non-POSIX variable name
qtsharp/src/bindings/Makefile.am:6: (probably a GNU make extension)
qtsharp/src/generator/Makefile.am:3: wildcard *.cs: non-POSIX variable name
qtsharp/src/generator/Makefile.am:3: (probably a GNU make extension)
qtsharp/src/uicsharp/Makefile.am:3: wildcard *.cs: non-POSIX variable name
qtsharp/src/uicsharp/Makefile.am:3: (probably a GNU make extension)

Looking around the web indicates the following possible solution:

=======================================
diff -urN tdebindings/korundum/rubylib/rbkconfig_compiler/Makefile.am tdebindings.new/korundum/rubylib/rbkconfig_compiler/Makefile.am
--- tdebindings/korundum/rubylib/rbkconfig_compiler/Makefile.am 2012-09-14 17:58:59.000000000 -0500
+++ tdebindings.new/korundum/rubylib/rbkconfig_compiler/Makefile.am 2012-11-28 10:01:55.000000000 -0600
@@ -2,7 +2,7 @@

 RBUIC=rbuic

-%.rb: %.ui
+.ui.rb:
  $(RBUIC) -tr ${UIC_TR} -kde $*.ui -o $@

 exampleprefs_base.rb: $(srcdir)/example.kcfg rbkconfig_compiler $(srcdir)/exampleprefs_base.kcfgc
diff -urN tdebindings/qtsharp/src/bindings/Makefile.am tdebindings.new/qtsharp/src/bindings/Makefile.am
--- tdebindings/qtsharp/src/bindings/Makefile.am  2012-09-14 17:59:01.000000000 -0500
+++ tdebindings.new/qtsharp/src/bindings/Makefile.am  2012-11-28 10:05:16.000000000 -0600
@@ -1,3 +1,5 @@
+AUTOMAKE_OPTIONS = -Wno-portability
+
 all: Qt.dll

 TQWidget.cs:
diff -urN tdebindings/qtsharp/src/generator/Makefile.am tdebindings.new/qtsharp/src/generator/Makefile.am
--- tdebindings/qtsharp/src/generator/Makefile.am 2012-09-14 17:59:01.000000000 -0500
+++ tdebindings.new/qtsharp/src/generator/Makefile.am 2012-11-28 10:08:50.000000000 -0600
@@ -1,3 +1,5 @@
+AUTOMAKE_OPTIONS = -Wno-portability
+
 all: generator.exe

 generator.exe: $(wildcard *.cs)
diff -urN tdebindings/qtsharp/src/uicsharp/Makefile.am tdebindings.new/qtsharp/src/uicsharp/Makefile.am
--- tdebindings/qtsharp/src/uicsharp/Makefile.am  2012-09-14 17:59:01.000000000 -0500
+++ tdebindings.new/qtsharp/src/uicsharp/Makefile.am  2012-11-28 10:08:01.000000000 -0600
@@ -1,3 +1,5 @@
+AUTOMAKE_OPTIONS = -Wno-portability
+
 all: uicsharp.exe

 uicsharp.exe: $(wildcard *.cs)
=======================================

The warnings disappear with the patch. Is this a legitimate patch to push upstream or are there more palatable fixes?

Darrell