Message: previous - next
Month: December 2012

Re: [trinity-devel] Commit 786e248c 2012-12-01 breaks tdebase in GIT

From: "Darrell Anderson" <darrella@...>
Date: Sun, 09 Dec 2012 14:25:25 -0600
>This is not a palatable solution. As mentioned, searching the web 
>reveals that including demangle.h in binutils is not something 
>that can be presumed. Although some distros have been patched, not 
>have been patched. Trinity has to build against stock distros and 
>not kludges.
>I've emailed the Slackware maintainer but there is no guarantee a 
>patched binutils is forthcoming.
>Can the original commit be rewritten to not use demangle.h? 
>Otherwise the only solution is reversing the original commit. I 
>believe that code was committed primarily as a troubleshooting aid 
>against bug report 1288. Therefore reversing the patch should not 
>cause any problems, but do we want to keep that code in GIT 
>permanently, even after bug report 1288 is resolved?

That commit is the only place in the entire GIT sources requiring a 
dependency on demangle.h. The only place the include is required is