trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2013

Re: [trinity-devel] kio_imap4 fix

From: François Andriot <francois.andriot@...>
Date: Wed, 29 May 2013 19:48:58 +0200
Le 29/05/2013 16:01, Sl�vek Banko a �crit :

> Sorry I made a typo in previous patch which could crash kio_imap4 (bad
> values comparison)
> Try this patch instead !
>
> Francois
> I tested both your patch, and your patch with the added:
>
>    parseRelay (relayData);
>
> (I believe this is missing in your patch), but the problem with
> termination connection in KOrn persists.
>
> Slavek


Yes, you're right, I forgot the parseRelay() call ! Oops !

BTW I now doubt that your Korn problem is related to these patches ...
Are you even sure that Korn uses the "relay" feature ?  I'm not.

I've just built and tested tdepim several times :
1) Without Serghei's patch: Korn works correclty
2) With Serghei's patch only: Korn works correctly
3) Serghei + yesterday's patch: Korn works correclty
4) Serghei + corrected "parseRelay" patch : still works correctly.

I have no imap disconnection at all ...
So, my guess is we still don't know really what's the "relay" feature is 
for , and all my patches are useless.

Francois