trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2013

Re: [trinity-devel] kio_imap4 fix

From: Slávek Banko <slavek.banko@...>
Date: Thu, 30 May 2013 22:44:47 +0200
On Thursday 30 of May 2013 19:43:20 François Andriot wrote:
> Le 30/05/2013 04:08, Slávek Banko a écrit :
> > On Friday 03 of May 2013 17:13:23 Serghei Amelian wrote:
> >> Hello,
> >>
> >> If anyone experienced this bug:
> >> http://lists.opensuse.org/opensuse-kde3/2012-03/msg00001.html
> >>
> >> try this patch:
> >> http://sourceforge.net/p/kde3/kdepim/ci/a32b14d7ababc08d76195a7382e5
> >>98329fb 7f0a2/
> >
> > I have prepared a completely alternative patch! When examining the
> > original code, I noticed that in myRead is used memcpy when moving
> > block within the buffer.
> >
> > This reminded me bug 737 and commit 65c85dca (tdebase). This commit
> > fixes in the POP3 protocol exactly the same case as in the original
> > code of IMAP protocol. Therefore, I have prepared a same patch for
> > IMAP (for original code - without your previously proposed patches).
> >
> > Please, try it.
> >
> > Slavek
>
> Nice find, your alternative patch fixes my parsing problems !
> For me it's OK to push it.
>
> Francois
>

Thank you for your effort and testing. Pushed to GIT in hash c830701a and 
also into v3.5.13-sru branch. I'm glad that we discovered soon enough 
that the previous proposed patch was incorrect.

Note: This could be the last patch before freezing source code for 
3.5.13.2 - leaving aside the patch for increase version in tdelibs :)

Slavek
--