> 2013/8/11 Timothy Pearson <kb9vqf@...> > >> Looks good, go ahead and push. What is happening is that it was brought >> to my attention that the TDE HW library API inadvertently assumed the >> usage of pmount in all cases. Therefore, I updated the API to use a >> more >> generic method of specifying mount options; apparently I missed a few >> users of the TDE HW library such as k3b. >> >> Tim >> > > It's steel not perfect: > - mediaName parameter is useless for most of other possible backends, so > it would be nice to pass it as a part of mountOptions map. > - the retcode is assumed to be the pmount's returned code it's better to > return a constant from some enum set. > > PS when you introduce the new API, you supposed to mark the old one with > KDE_DEPRECATED rather than just replace it. > or at least please make some announce at list before performing such > changes... > R14 is still in development, so I don't need to use KDE_DEPRECATED. After release then yes, I would need to do that, hence the urgency of the API change. :-) mediaName will stay as I consider it a defect (albiet one out of our control) if a backend is not able to use a user-defined mount label. retcode can be changed to an enum without any ABI problems, so this is not too high on my list of priorities. Tim