trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: January 2014

Re: [trinity-devel] tdebindings renaming/rebranding patch

From: "Darrell Anderson" <darrella@...>
Date: Tue, 07 Jan 2014 19:06:54 -0600
>1) Names of java classes are derived from the domain name. I 
>watched that 
>tde.org domain is owned by The Duke Endowment. Although it seems 
>that this 
>domain is not used, I think it would be appropriate instead of 
>org.tde.* use 
>our domain - org.trinitydesktop.* What is your opinion?

Sounds fine to me!

>2) In the patch was typo - slash before 'org' was sometimes 
>doubled.
>
>Fixed.

Wow, if that is all you found then I am flabbergasted. I know 
nothing about java and much of my patching was pure guessing. I 
focused only on renaming kde->tde.

Well, the old adage is true: even blind hogs occasionally find 
nuts. :)

>An updated patch is available in my 'rsync' resource tde-patches-
>verify. I tried to build and was successful.

If you are content then push to git. :)

Darrell