trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: January 2014

Re: [trinity-devel] Filename change kfileividesktop.cpp -> tdefileividesktop.cpp (but patch not applied)

From: "David C. Rankin" <drankinatty@...>
Date: Sat, 18 Jan 2014 22:39:38 -0600
On 01/18/2014 09:04 PM, Darrell Anderson wrote:
> I don't know what you mean by traditional patch files.
> 
> If you are still applying patches from years ago, then likely you 
> will make a mess. :)
> 
> The only patches I apply these days are patches in the queue from 
> the bugzilla or patches I create for testing. There are no more 
> traditional patch files. Those days are long gone.
> 
> Check the git history for patches:
> 
> http://git.trinitydesktop.org/cgit/
> 
> You can narrow your search to specific cpp files.
> 
> If you find no evidence a patch was applied --- and that includes 
> remembering to check against all of the renaming and rebranding, 
> then check the bugzilla. There remain many open bug reports with 
> patches that have not been merged into git.

That is what I'm talking about - needed patches that fix basic flaws in the code
that were traditionally applied to the kde3 codebase that have never been
incorporated into the tde git tree.

This patch file 08-kip_kdesktop_rounded_icon_text_corners.patch fixes the square
corners on desktop icon text improving the fit/finish of the desktop. It has
never made it into the code - but should:

   // draw the pixmap as in KIconViewItem::paintItem(...)
   paintPixmap(p, colors);
+  if ( isSelected() ) {
+    p->setBrush( TQBrush( cg.highlight() ) );
+    p->setPen( TQPen( cg.highlight() ) );
+    p->drawRoundRect( textRect( FALSE ),
+                      1000 / textRect( FALSE ).width(),
+                      1000 / textRect( FALSE ).height() );
+  }

The patches seem were produced on 1/30/12 and contain TQWidget, etc.. so they
came from the tde code. I'm getting too old to remember exactly the source, but
they were provided to me some time during that time frame to apply to the code
to fix issues. I have used them in all my builds since. I know I didn't produce
them because they have far to consistent naming than I would have come up with
hacking patches :-)

I know there were about 12 or so to begin with and out of that I removed all but
the ones that were still required. Those that are still required are:

01-kicker-lockout-applet-button-order.patch
03-kcontrol_advbg_step.patch
06-nspluginscan-xdgcompliance.patch
08-kip_kdesktop_rounded_icon_text_corners.patch

I've attached what I am currently using.


-- 
David C. Rankin, J.D.,P.E.

Attachments: