trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2014

Re: [trinity-devel] kmymoney - kmymoneytitlelabel.png is missing from TDE source (causing 'install' FBFS)

From: Slávek Banko <slavek.banko@...>
Date: Wed, 19 Feb 2014 02:23:36 +0100
On Tuesday 18 of February 2014 23:00:24 David C. Rankin wrote:
> On 02/18/2014 03:36 PM, David C. Rankin wrote:
> > On 02/18/2014 03:30 PM, David C. Rankin wrote:
> >> All,
> >>
> >>   Working further with kmymoney, I have run across a build failure due
> >> to a missing icon: kmymoneytitlelabel.png. The failure occurs at the end
> >> of the build during the packaging stage:
> >>
> >>   /usr/bin/install -c -p -m 644
> >> /build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/$file
> >> /build/tde-kmymoney/pkg/tde-kmymoney/opt/trinity/share/apps/kmymoney2/pi
> >>cs; \ done
> >> /usr/bin/install: cannot stat
> >> '/build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/kmymoneytitlelabel.p
> >>ng': No such file or directory
> >>
> >>   The icons is not in the tde git tree:
> >>
> >> 15:23 phoinix:/dat_e/tde/tde/main/applications/kmymoney> find . -name
> >> kmymoneytitlelabel.png
> >> <nothing>
> >>
> >>   The build system looks for the icon here:
> >>
> >> kmymoney2/widgets/Makefile:689:WIDGET_PNGS = kmymoneytitlelabel.png
> >> kmymoney2/widgets/Makefile.am:54:WIDGET_PNGS = kmymoneytitlelabel.png
> >> kmymoney2/widgets/Makefile.in:689:WIDGET_PNGS = kmymoneytitlelabel.png
> >>
> >>   Does anyone have a patch/substitute for this icon? It is apparently
> >> triggered when building with 'libofx' features enabled:
> >>
> >>   ./configure \
> >>     --prefix=${TDEDIR} \
> >>     --with-qmake=${QTDIR}/bin/tqmake \
> >>     --with-qt-dir=${QTDIR} \
> >>     --with-qt-includes=${QTDIR}/include \
> >>     --with-qt-libraries=${QTDIR}/lib \
> >>     --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \
> >>     --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \
> >>     --sysconfdir=${TDEDIR}/etc \
> >>     --localstatedir=/var \
> >>     --disable-dependency-tracking \
> >>     --disable-gcc-hidden-visibility \
> >>     $enable_pdfdocs \
> >>     --enable-new-ldflags \
> >>     --enable-rpath \
> >>     --enable-ofxplugin \
> >>     --enable-ofxbanking \
> >>     --enable-qtdesigner \
> >>     --disable-sqlite3 \
> >>     --enable-qtdesigner \
> >>     --disable-debug \
> >>     --disable-final \
> >>     --enable-closure
> >>
> >>   I am tinkering with enabling more of the options after Francios
> >> confirmed he was able to build with those options enabled. The build
> >> completed fine, the packaging of the icon is the problem.
> >
> > Here is the answer from the changelog at sourceforge:
> >
> > 2011-05-21 06:32  conet
> >
> > 	* kmymoney/widgets/CMakeLists.txt,
> > 	  kmymoney/widgets/kmymoneytitlelabel.png: Remove unused file.
> >
> > http://kmymoney2.sourceforge.net/ChangeLog-4.5.95.txt
> >
> > I'll work on a patch.
>
> The easiest fix is just to add the missing icon back to the tde git tree,
> since the icon IS required for the TDE build. I have obtained a copy of the
> icon from one of Francios old packages and kmymoney then builds fine. The
> old package containing the icon was:
>
> ftp://fr2.rpmfind.net/linux/sourceforge/m/ma/magiclinux-plus/update30/RPMS.
>trinity/trinity-kmymoney-common-1.0.5-4mgc30.opt.x86_64.rpm
>
> The icon is attached. Darrell/Slavek/Francios please push this icon to git
> in the /tde/main/applications/kmymoney/kmymoney2/widgets directory.
>
> This icon is very much needed in the TDE version of kmymoney with the
> options above.

Interesting. I checked build.log and in my building kmymoneytitlelabel.png is 
not asked. 

I tried to find out if this icon is sometimes used, and I could not find any 
place. It would be better instead of returning unused image, cancel the 
installation of this image?

Slavek
--