trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2014

Re: [trinity-devel] kmymoney - kmymoneytitlelabel.png is missing from TDE source (causing 'install' FBFS)

From: "David C. Rankin" <drankinatty@...>
Date: Tue, 18 Feb 2014 20:16:35 -0600
On 02/18/2014 07:23 PM, Slávek Banko wrote:
> Interesting. I checked build.log and in my building kmymoneytitlelabel.png is 
> not asked. 
> 
> I tried to find out if this icon is sometimes used, and I could not find any 
> place. It would be better instead of returning unused image, cancel the 
> installation of this image?
> 
> Slavek

Slavek,

  Do you think that just out-of-the-blue I did something like wiggle my left ear
and presto "this build shall try to install kmymoneytitlelabel.png?"

  No, somewhere in the code that icon IS required. Just as I posted it is
required by:

kmymoney2/widgets/Makefile:689:WIDGET_PNGS = kmymoneytitlelabel.png
kmymoney2/widgets/Makefile.am:54:WIDGET_PNGS = kmymoneytitlelabel.png
kmymoney2/widgets/Makefile.in:689:WIDGET_PNGS = kmymoneytitlelabel.png

  I makes a heck of a lot more sense to simply add a 500 byte icon back to the
tree than spend 10 hours hacking the code telling it not to install. It wouldn't
be asked for if it wasn't needed. Now without it in the code, the build fails --
or if you hack the build to prevent install, there will be something without an
icon. There are more than enough somethings without icons in TDE.

  Just add the icon.....

-- 
David C. Rankin, J.D.,P.E.