trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: October 2014

Re: [trinity-devel] CMake CMP0046 changes

From: "Timothy Pearson" <kb9vqf@...>
Date: Mon, 6 Oct 2014 13:06:16 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224

> On Monday 06 of October 2014 16:33:30 Slávek Banko wrote:
>> On Monday 06 of October 2014 06:47:36 Michele Calgaro wrote:
>> > On 10/06/2014 01:10 PM, Timothy Pearson wrote:
>> > > -----BEGIN PGP SIGNED MESSAGE-----
>> > > Hash: SHA224
>> > >
>> > > Slavek, all,
>> > >
>> > > When building TDE on Debian Jessie I have run into several instances
>> > > where tdebase FTBFS due to the recent changes in CMake policy
>> CMP0046.
>> > > Setting the OLD behavior repairs the problem.
>> > >
>> > > Are there any drawbacks to setting CMP0046 OLD globally?  If not can
>> > > one of the CMake gurus here please push a proper patch to the cmake
>> > > module ASAP?
>> > >
>> > > Thanks!
>> > >
>> > > Tim
>> > > -----BEGIN PGP SIGNATURE-----
>> >
>> > Tim,
>> > I always build on Jessie and haven't run in any FTBFS due to CMP0046
>> (at
>> > least until last Saturday). Nevertheless looking at some log files I
>> can
>> > see warnings about that.
>> > We can push a patch similar to the one pushed in commit 0d5ca8be for
>> > CMP0026. But given the reasons of such warning:
>> >
>> > "Error on non-existent dependency in add_dependencies.
>> > CMake 2.8.12 and lower silently ignored non-existent dependencies
>> listed
>> > in the add_dependencies() command.
>> > The OLD behavior for this policy is to silently ignore non-existent
>> > dependencies. The NEW behavior for this policy is to report an error
>> if
>> > non-existent dependencies are listed in the add_dependencies()
>> command."
>> >
>> > IMO it would be better to remove or fix the non-existent dependency.
>> >
>> > Perhaps we can push a patch temporarily for v14.0.0 and file a bug
>> > report against fixing all non-existent dependencies for after v14.0.0.
>> >
>> > What do you think?
>> >
>> > Cheers
>> >    Michele
>>
>> I tried it just now - yes I see many reports CMP0046. However, not
>> caused
>> FTBFS. I'll look at it more closely.
>
> Well, I looked and really this is a bug. For tdebase fixed in commit
> aaf2ebb5.
> Setting the CMP0046 to OLD therefore I consider inappropriate. As we
> discover
> CMD0046 messages, then should be corrected.
>
> --
> Slávek

Thanks for looking into this.  I wasn't sure if the FTBFS was just a
glitch on my system.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iFYEARELAAYFAlQy2hcACgkQLaxZSoRZrGECXwDfbP1Mu06Ot53lcgaIb/z+La0b
rhl9/u8z1SAyfADfTF1mIxJQA+EIttoHH/gkpIdMU9eBui7wdLRWWA==
=BF5l
-----END PGP SIGNATURE-----