trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: October 2014

Re: [trinity-devel] R14 hard freeze for RC1

From: "Timothy Pearson" <kb9vqf@...>
Date: Thu, 23 Oct 2014 00:26:15 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224

> Le 23/10/2014 05:02, Timothy Pearson a écrit :
>>
>> Just wanted to remind everyone that TDE is back in hard freeze while we
>> wait for the RC1 rebuilds after the recent changes to the common admin
>> module.  The build farm should have R14 RC1 built in the next couple of
>> weeks.
>>
>> As there were a number of changes to the icon names I need volunteers to
>> go through RC1 and carefully look for any missing icons (e.g. buttons,
>> dialogs, toolbars, etc. showing up with the default "unknown" icon
>> instead
>> of the correct icon).  I have scoured the tree carefully for errors as
>> of
>> this point (there was a LOT of manual work involved in renaming the
>> icons), but it is possible that some incorrect names slipped through
>> anyway.
>>
>> Thanks!
>>
>> Tim
>>
>
> Hello,
>
> FTBFS today in tdeaccessibility:
>
> In file included from ksayit.all_cpp.cpp:15:0:
> docbookclasses.cpp: In constructor
> 'KeywordSet::KeywordSet(ListViewInterface*, ListViewInterface*,
> TQString)':
> docbookclasses.cpp:451:59: error: expected ')' before 'text'
>       TQPixmap pixmap = TDEGlobal::iconLoader()->loadIcon(""text-plain",
> TDEIcon::Small);
>                                                             ^
> In file included from DocTreeView.cpp:18:0,
>                   from ksayit.all_cpp.cpp:19:
> ./DocTreeView.ui.h: At global scope:
> ./DocTreeView.ui.h:129:6: warning: unused parameter 'i'
> [-Wunused-parameter]
>   void DocTreeView::slotRightButtonPressed( TQListViewItem *i, const
> TQPoint &, int )
>        ^
> In file included from ksayit.all_cpp.cpp:10:0:
> ksayit.cpp: In member function 'void
> KSayItApp::slotChangeBookmarkFilename(const TQString&)':
> ksayit.cpp:297:38: warning: ignoring return value of 'int system(const
> char*)', declared with attribute warn_unused_result [-Wunused-result]
>               system( command.ascii() );
>                                        ^
> make[4]: *** [ksayit.all_cpp.o] Error 1
> make[4]: Leaving directory
> `/dev/shm/BUILD.oss131.x86_64/trinity-tdeaccessibility-14.0.0~pre214+e0af5b18/ksayit/src'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory
> `/dev/shm/BUILD.oss131.x86_64/trinity-tdeaccessibility-14.0.0~pre214+e0af5b18/ksayit'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory
> `/dev/shm/BUILD.oss131.x86_64/trinity-tdeaccessibility-14.0.0~pre214+e0af5b18'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory
> `/dev/shm/BUILD.oss131.x86_64/trinity-tdeaccessibility-14.0.0~pre214+e0af5b18'
>
>
> There is a type, duplicate "" in loadIcon
>
> François

Whoops!  If anyone sees this kind of stuff feel free to fix it; it won't
hurt the ongoing builds as (obviously) they would fail on the build farm
as well.

Fixed in GIT.

Did I mention that the icon renaming was a lot of extremely tedious manual
work? ;-)

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iFYEARELAAYFAlRIkXYACgkQLaxZSoRZrGEj/QDguAlwC3NiUHvoIKBA+0pg5QQS
36krzLNJX6F+AADfUWpfKtfYGplyFeqPT6zgz1B+XDP1nao7DDB2Wg==
=LJ22
-----END PGP SIGNATURE-----