Message: previous - next
Month: October 2014

Re: [trinity-devel] new website - patches

From: "E. Liddell" <ejlddll@...>
Date: Fri, 24 Oct 2014 17:33:19 -0400
On Sun, 19 Oct 2014 22:23:17 -0400
Calvin Morrison <mutantturkey@...> wrote:

> Even if you don't adopt anything new, you could reduce the amount of
> bandwidth by quite a bit by not writing valign=TOP width=50% and using css
> to accomplish the same

Okay, I've had a chance to take a look at this now, and two sets of
fixes are required:

In the HTML page:

-Change the table element to <TABLE CLASS="patchtable">

-Change the header row to use <TH> elements rather than going to the 
trouble of <TD><B>

-Remove all the VALIGN=TOP notations.

-While it has nothing to do with the table styles, the <s at the beginning of 
the email addresses really should be encoded as &lt; .  Currently, the
W3C's validator detects more than 200 errors on this page, nearly all
of them due to this.

To the stylesheet, add the following:

/*patches table*/
.patchtable TR TD {vertical-align:top}
.patchtable TR TH {text-align:left;
.patchtable {width:100%;}

If you want to put the 50% width constraint for the last cell back in, also
add the line:

 .patchtable TR TD:last-child {width:50%;}

Surprisingly, even Konqueror understands this selector, despite it technically 
being a CSS3 construct.

This is not sufficient to make the table fit correctly on small screens at a sane 
font size--for that, you need to cut down those date columns, as I mentioned 
before.  It's also much grumpier about reducing correctly with the new,
white-border-less design than it was with the original.

I'm going to look at the Bugzilla skin now.

E. Liddell