trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: October 2014

Improvements to the "Patches from GIT" web page

From: Michele Calgaro <michele.calgaro@...>
Date: Sun, 26 Oct 2014 12:22:04 +0900
The new "patches from GIT" page looks good and so does the search field 
at the bottom. Anyhow IMO there are still a few things to fix:

1) email addresses are shown in full, which is not that good being a 
page available without any login.
It would be advisable to remove them, both from the committer column and 
the Log message column (for signed-off commits).

2) I believe the correct name of the committer column should be "Author"

3) The page still displays with problems if the width of the browser 
window is small enough (the blue left side menu overlaps the page contents)

4) The search field would probably be better if it was at the top, since 
it does not take up much page space. At the moment we need to scroll the 
whole page if we want to search for a particular commit

5) the 'page navigation' (the one saying 'Now viewing patches...') would 
be better if it had links to the next and previous adjacent pages as in 
most search engines (something like [1], [2], [3], .... to make it clear)

6) IMO, the name "Patches from GIT" is misleading for new users, as I 
already said in a previous email. Would be better to call it "GIT 
Commits" or "Commit history" or something with "commit" in it

Hope this is useful.
Cheers
   Michele