trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2016

CMake + tdelfeditor × versioned libraries

From: Slávek Banko <slavek.banko@...>
Date: Mon, 14 Mar 2016 22:18:30 +0100
Hi all,

I noticed one problem regarding the cmake build of libraries with versioning 
and tdelfeditor. Tdelfeditor is used not only on file with the appropriate 
version, but also on base 'so' file without a version number. However, this 
is a symlink to the file with the appropriate version. Use tdelfeditor causes 
that instead of this symlink is created a regular file. Results are then two 
full 'so' files, which is incorrect. For example, in tdebase (current stable 
R14.0.3 Wheezy@amd64):

  libkonq.so - size 809232 (package libkonq4-trinity-dev)
  libkonq.so.4.2.0 - size 809240 (package libkonq4-trinity)

Solutions should be simple: in the common cmake module run tdelfeditor only on 
libraries with the appropriate version and on base files only if the library 
is not versioned. In some cases tdelfeditor is used, although library is not 
shared == tdelfeditor is started without valid arguments. See proposed patch.

I believe that there is no reason against to push the patch. There will be 
only one consequence - the patch causes rebuild almost all packages.

-- 
Slávek

Attachments: