trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2016

Re: [trinity-devel] CMake + tdelfeditor × versioned libraries

From: Slávek Banko <slavek.banko@...>
Date: Tue, 15 Mar 2016 20:22:21 +0100
Dne út 15. března 2016 Fat-Zer napsal(a):
> 2016-03-15 17:03 GMT+03:00 Slávek Banko <slavek.banko@...>:
> > Dne út 15. března 2016 Slávek Banko napsal(a):
> >> Your observation is correct. Perhaps it would be appropriate to use
> >> find_program with hints "${TDE_PREFIX}/bin" and ${BIN_INSTALL_DIR} -
> >> just like is in search for tde-config. And then use the value
> >> ${TDELFEDITOR_EXECUTABLE}. What do you think?
> >
> > Proposed patch attached.
> >
> > --
> > Slávek
>
> Looks good... Note that you may still get rid of the "if (_version)"
> with something like «get_target_property ( _lib_location ${_target}
> LOCATION )» if you wish...
>

A few lines above in the TDEMacros is the part that uses:

 get_target_property( _output ${_target} LOCATION )

However, even in this section is also used ${_version}. It believe that 
LOCATION returns the name of the library without version.

-- 
Slávek