trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2016

Re: Re: Re: Re: testing: tdeabc/vcardparser$ more README.testing [solved]

From: deloptes <deloptes@...>
Date: Tue, 10 May 2016 12:54:03 +0200
Slávek Banko wrote:

> On Monday 02 of May 2016 08:05:36 deloptes wrote:
> 
> You can try to use the supplied patch. It is a little simpler and uses
> standard TDE macros.
> 

Hi,
attached the final patch for the vcardparser, vcardformatplugin and testing.

The final problem identified in vcardformatplugin 

--- a/tdelibs.orig/tdeabc/vcardformatplugin.cpp
+++ b/tdelibs-trinity-14.0.3/tdeabc/vcardformatplugin.cpp
@@ -41,7 +41,7 @@ bool VCardFormatPlugin::load( Addressee &addressee, TQFile
*file )
   TQString data;

   TQTextStream t( file );
-  t.setEncoding( TQTextStream::Latin1 );
+  t.setEncoding( TQTextStream::UnicodeUTF8 );
   data = t.read();

but writing to the file sets TQTextStream::UnicodeUTF8.

Patch by Fat-Zer included and testing stuff as explained in the previous
message.

I tested it already and don't see any issue.
It is however debatable if we should not test encoding based on locale, but
I doubt someone today is using something different than utf8

regards

Attachments: