trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: September 2016

Re: [Bulk] [trinity-devel] Re: [Solved] [trinity-devel] Re: How to test tdeioslave/trash

From: deloptes <deloptes@...>
Date: Sat, 24 Sep 2016 13:32:39 +0200
Michele Calgaro wrote:

> On 2016/09/24 04:49 AM, deloptes wrote:
>> Hi,
>> I was able to get the dialog visible in the properties window.
>> I also know now how to test such things.
>> 
>> This plugin (library) is service.
>> In the .desktop file I write now
>> 
>> [Desktop Entry]
>> Type=Service
>> Name=Trash Properties Page
>> Name[bg]=Свойства на кошчето
>> X-TDE-Library=ktrashpropsdlgplugin
>> X-TDE-ServiceTypes=KPropsDlg/Plugin,media/builtin-trash
>> 
>> the file goes in
>> 
>>         /opt/trinity/share/services/ktrashpropsdlgplugin.desktop
>> 
>> After this run
>>         tdebuildsycoca
>> 
>> Now right click and select properties on the trashbin and watch
>> in .xsession-err...
>> 
>> tdeio (KSycoca): Trying to open tdesycoca
>> from /var/tmp/tdecache-emanoil/tdesycoca
>> tdeio (TDETrader): query for ThumbCreator : returning 14 offers
>> tdeio (TDETrader): query for media/builtin-trash : returning 0 offers
>> tdeio (TDEIOJob): stat
>> file:///opt/trinity/share/apps/kdesktop/Desktop/Trash tdeio_file:
>> FileProtocol::stat details=2 tdeio (TDETrader): query for ThumbCreator :
>> returning 14 offers tdeio (TDETrader): query for media/builtin-trash :
>> returning 1 offers
>> 
>> The issue now is that it does not save the values set in the dialog
>> window.
> 
> Great work, Emanoil. Keep it up, it would be a good addition for R14.1 :-)
> 
> Cheers
>   Michele

Yes, indeed it was a good exercise.
I uploaded 2 patches for the plugin code and for the debian installer.
Tested OK.

The only think I dislike here is that the granularity is set to 3 but the
step can be only 1. It gets ugly when you go for value < 1.

https://api.kde.org/3.5-api/kdelibs-apidocs/kdeui/html/classKDoubleSpinBox.html
https://api.kde.org/3.5-api/kdelibs-apidocs/kdeui/html/knuminput_8cpp_source.html

IMO it should depend on the size and unit, but lets leave some work for the
future. We could open a new bug to fix this later.

If someone can test more of it, it would be great.

regards

PS: thank you all for the patience and good mentoring so far.