trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2018

Re: [trinity-devel] TQt buildkey with GCC >= 7

From: Slávek Banko <slavek.banko@...>
Date: Wed, 16 May 2018 08:47:03 +0200
On Wednesday 16 of May 2018 08:24:41 Michele Calgaro wrote:
> On 2018/05/09 04:56 PM, Slávek Banko wrote:
> > Hello to all developers,
> >
> > following the arrival of GCC 8.x, I began to address the build key
> > update in TQt. See the patch that was pushed for GCC 7.x:
> >
> >   https://mirror.git.trinitydesktop.org/cgit/tqt3/commit/?id=71d8f1c4
> >
> > Now I noticed that starting with GCC7, the compiler reports the
> > version in a different way. Previously, gcc -dumpversion returned for
> > example: 6.3.0. Now, regardless of the specific version of GCC 7.x or
> > 8.x, it simply return: 7 or 8.
> >
> > Because the binary programs are compatible, the expression
> > "7.*|6.*|5.*| 4.*)" in the configuration assured that for the GCC
> > from 4.x to 6.x the build key was generated as follows:
> >
> > #define TQT_BUILD_KEY "x86_64 Linux g++-4.* full-config"
> >
> > But the gcc -dumpversion behavior change in GCC >= 7 has caused that
> > the expression in the configuration not to be applied to GCC versions
> > >= 7 and the build key is generated as follows:
> >
> > #define TQT_BUILD_KEY "x86_64 Linux g++-7 full-config"
> >
> > I believe that when binary programs are still compatible, we want to
> > keep the build key identical (x86_64 Linux g++-4.* full-config), and
> > I suggest modifying the expression in the configuration as follows:
> >
> > --- a/configure
> > +++ b/configure
> > @@ -2818,7 +2818,7 @@ g++*)
> >      3.*)
> >         COMPILER_VERSION="3.*"
> >         ;;
> > -    7.*|6.*|5.*|4.*)
> > +    [7-8]|[4-6].*)
> >         COMPILER_VERSION="4.*"
> >         ;;
> >      *)
> >
> > Please, what is your opinion?
> >
> > Cheers
>
> Hi Slavek,
> Late reply (already seen the commits). The solution sounds good to me
> too. Cheers
>  Michele

Just a small note - after a buildkey change in TQt, it is necessary to 
rebuild tdelibs.

Cheers
-- 
Slávek