trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: August 2018

Re: [trinity-devel] TDE on FreeBSD 11.2-p1 failes to build: tqtinterface

From: "Dr. Nikolaus Klepp" <office@...>
Date: Tue, 7 Aug 2018 02:15:11 +0200
Am Dienstag, 7. August 2018 schrieb Slávek Banko:
> On Tuesday 07 of August 2018 01:51:15 Dr. Nikolaus Klepp wrote:
> > Am Dienstag, 7. August 2018 schrieb Slávek Banko:
> > > On Tuesday 07 of August 2018 00:31:31 Dr. Nikolaus Klepp wrote:
> > > > Hi all!
> > > >
> > > > Ok, found another thing: tqt3 installes the file
> > > > /usr/local/include/tqt3/ntqgplugin.h, which fails to compile
> > > > tqtinterface. The origilal content of file
> > > > /usr/local/include/tqt3/ntqgplugin.h, line 83, is:
> > > >
> > > >     static const char *qt_ucm_verification_data =           \
> > > >             "pattern=""QT_UCM_VERIFICATION_DATA""\n"		\
> > > >             "version="TQT_VERSION_STR"\n"             \
> > > >             "flags="Q_PLUGIN_FLAGS_STRING"\n"             \
> > > >         "buildkey="TQT_BUILD_KEY"\0";
> > > >
> > > > This sould be:
> > > >
> > > >     static const char *qt_ucm_verification_data =           \
> > > >             "pattern=""QT_UCM_VERIFICATION_DATA""\n"		\
> > > >             "version=""TQT_VERSION_STR""\n"             \
> > > >             "flags=""Q_PLUGIN_FLAGS_STRING""\n"             \
> > > >         "buildkey=""TQT_BUILD_KEY""\0";
> > > >
> > > >
> > > > Then tqtinterface compiles.
> > > >
> > > > Nik
> > >
> > > Yes, I know - that why there are additional patches in the FreeBSD
> > > folder - see, for example:
> > >
> > > http://mirror.git.trinitydesktop.org/cgit/tde-packaging/tree/freebsd/
> > >dependencies/tqt3/files?h=r14.0.x
> > >
> > > Please check that you have all the current files from tde-packaging /
> > > freebsd. Here are some patches related to stricter C++11 in Clang.
> > >
> > > Cheers
> >
> > I just pulled again, but the path you mentioned was not applied. If I
> > recall correctly, then the mirror is a bit behind. I think I'll pull
> > and rebuild tomorrow, but it's building kmail right now and I don't
> > want to interrupt :-)
> >
> > Nik
> 
> The mirror is delayed for only one hour in normal condition. In addition, 
> the link I sent to you was just to mirror == patches are available on 
> mirror. That's why I say - check it again :)
> 
> See full commit (on mirror):
> 
> http://mirror.git.trinitydesktop.org/cgit/tde-packaging/commit/?h=r14.0.x&id=90100478
> 
> Cheers

Ok, I misread the patch. The patch you linked was already applied, but by the "patch-bp000-fix-ftbfs-on-c++11.diff" the doublequotes are not replaced by the double-doublequotes (as I had to do), it just inserts a space before the last doublequote of each line (which was already applied).

Nik


-- 
Please do not email me anything that you are not comfortable also sharing with the NSA, CIA ...