trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2011

Re: [trinity-devel] Adding: #include <cstddef> to headers AS FOUND - is it doable?

From: /dev/ammo42 <mickeytintincolle@...>
Date: Tue, 10 May 2011 00:37:54 +0200
Le Mon, 09 May 2011 17:18:11 -0500,
"David C. Rankin" <drankinatty@...> a écrit :

> Tim, Serghei,
> 
>    As we find the headers that need to be patched with '#include
> <cstddef>', can those be updated in SVN?  Is there any reason not?
> If adding the include won't impact those building on gcc < 4.6, then
> I say we do it so that the code is 4.6 compliant and won't need
> fixing later.
If #include'ing <cstddef> to a header breaks compilation of the code
with any compiler, there are serious problems with the code and they
shall be solved.
> 
>    What say the experts?
> 
>    So far I have:
> 
> kdegraphics:
> 
> --- kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h
> +++ kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h
> 2011-05-08 11:47:20.000000000 -0500
> @@ -56,6 +56,7 @@
> 
>   #ifndef _GSMARTPOINTER_H_
>   #define _GSMARTPOINTER_H_
> +#include <cstddef>
>   #ifdef HAVE_CONFIG_H
>   #include "config.h"
>   #endif
> 
> 
>    They can be handled in the build scripts, but I would like to
> minimize the proliferation of patch files and eliminated the if
> "already applied" then "don't patch again dummy" fi statements :p
> 
>