trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: September 2011

Re: [trinity-devel] [cmake][kdbase] necessity of add_subdirectory

From: Serghei Amelian <serghei@...>
Date: Sat, 17 Sep 2011 14:30:28 +0300
On Saturday 17 September 2011 14:01:01 Fat-Zer wrote:
> 2011/9/17 Serghei Amelian <serghei@...>
>
> > On Saturday 17 September 2011 12:47:20 Fat-Zer wrote:
> > > Hi. I'm not sure if I'm writing the right mailing list so sorry if it
> >
> > isn't
> >
> > > so. Also sorry for my not very good english...
> > >
> > > Is there any special need for using "add_subdirectory " insted of
> > > "tde_conditional_add_subdirectory" for kcontrol, kdmlib etc?
> >
> > I'm not sure that I undestand your problem. The purpose
> > of "tde_conditional_add_subdirectory" is to include a directory only if
> > the condition is true (as the name suggests).
> >
> > > I think it's better to include all subdirectories via tde's function...
> > > isn't it?
> >
> > For what reason?
>
> Thanks for quick reply...
> I'll start from the beginning: I'm writing live ebuilds for trinity now and
> run into that there are same files are in each package from kdebase.

Good news, unfortunately my spare time became very little and I can't be 
productive as before.

> General reason: i think the system should compile only that you asked
> for... Patch in the attach will describe better what i'm talking about...

Actually, I did this everywhere was possible. For example, if you looking into 
kcontrol/CMakeLists.txt you will notice that "background" directory is needed 
for kdesktop and kdm either.

> ps: thanks for your repository on the githup (i wrote directly to you
> several months ago)... it helped me to start...

Welcome.

-- 
Serghei