trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: November 2011

Re: [trinity-devel] Can't login with KDM

From: Laurent Dard <f.couperin@...>
Date: Sat, 19 Nov 2011 00:44:06 +0100
Le 19/11/2011 00:11, Serghei Amelian a écrit :
> On Friday 18 November 2011 23:24:29 Timothy Pearson wrote:
> [...]
> 
>> Sorry about that.  Can you create a patch for the TDE CMake files, based
>> on the TDE v3.5.13 source tarballs, that enables the libcrypt-dependent
>> code in kdebase?  Right now the libcrypt-dependent code is disabled when
>> built under CMake because of an unset C++ #define and a missing linker
>> flag.
>>
>> Thanks!
>>
>> Tim
> 
> The patch is attached. Seems that kdm is the only kdebase application wich use 
> libcrypt.

> check_function_exists( crypt LIBC_HAVE_CRYPT )
> if( LIBC_HAVE_CRYPT )
>   set( HAVE_CRYPT 1 CACHE INTERNAL "" FORCE )
> else( )
>   check_library_exists( crypt crypt "" HAVE_CRYPT )
>   if( HAVE_CRYPT )
>     set( CRYPT_LIBRARY crypt )
>   endif( )
> endif( )

I doubt the first test is useful.
I believe check_function_exists always fails here.

$ man 3 crypt
--> "Link with -lcrypt."

This would be better, no?:

check_library_exists( crypt crypt "" HAVE_CRYPT )
if( HAVE_CRYPT )
  set( CRYPT_LIBRARY crypt )
endif( )


-- 
Laurent Dard