Message: previous - next
Month: February 2012

Re: [trinity-devel] Plan B

From: Calvin Morrison <mutantturkey@...>
Date: Fri, 17 Feb 2012 22:05:54 -0500
On 17 February 2012 22:00, Darrell Anderson <humanreadable@...> wrote:
>> I would love to review patches. for some time I have been
>> wanting to set up a review board... but I am sure an etherpad could
>> work just as well for now!
> Do we need etherpad? How about 3 to 4 people on a review committee. Each reviewer receives all emails from bugzilla. Two reviewers are needed to approve a patch. All that is needed is for a reviewer to add a comment "Patch Approved." Tim will see those comments through the bugzilla emails and then can push the patch.

Right once marked Patchavail we can automatically assign the bug to
reviewers. they can OK it and change the status to "needs merging"
(still requires tim having a role) or can push it themselves (easier,
but more likely for a bad commit)

> Similarly for bug reports with no patches. Any reviewer who receives an email for a new bug report and notices the report is build related but not tagged Blocker, can quickly update the bug report. Any of us can now do that but looks much better when a reviewer bumps the report within an hour or two.

Yeah, I was thinking a trinity-bugzilla ML where bugzilla would mail
out new bug reports. It's doable with bugzilla's tools. I try and look
over new bugs, but getting an email would be good as well.