trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2012

Re: [trinity-devel] gtk-qt-engine KDE -> TDE issues + patch to push

From: Darrell Anderson <humanreadable@...>
Date: Tue, 20 Mar 2012 20:25:03 -0700 (PDT)
> signoff, looks good to me.
> 
> Darrell can you push this?
> 
> As an aside, for things like this which are trivial, should
> we just have a person or two verify it by responding saying
> "signoff" or "seems ok!" at which point it should be merged by Darrel? we
> vaguely talked about this in another thread.
> 
> That was we don't need to file bugs for small issues.

I will push branding type patches without a "signoff" because they all are text string replacements --- after I test them here. :)

Otherwise I'll wait for a peer to "signoff." If I am uncomfortable pushing a particular patch then we create a bug report and attach the patch there.

Darrell