trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2012

Re: [trinity-devel] bug #908 fix

From: Darrell Anderson <humanreadable@...>
Date: Sat, 31 Mar 2012 14:13:44 -0700 (PDT)
> I just used:
> 
> calvin@boxi:~/builds/tde/main/tdebase$ patch -p0 < fixedup.patch
> 
> and it worked (except for a failed hunk, no idea why, it's
> just two lines

I don't know why they won't work here.

> and I am attaching the new patch which should work.

Old patch (edited by me) works. New patch is "malformed"?

Regardless, the new option works. Good job!

Next I get sidetracked noticing the patch modifies pagersettings.kcfg. After installing the rebuilt package I searched my system for pagersettings.kcfg.

No such file in /opt/trinity/share/config.kcfg/. No pagersettings.kcfg installed anywhere. Not in the rebuilt package either. Where did that file go?

I looked at the CMakeLists.txt and there is no "install" directive to install pagersettings.kcfg. I next looked at the original Makefile.am and there is no directive there, which explains why none exist in CMakeLists.txt.

Has this been broken for years in KDE3?

I added a directive to CMakeLists.txt and created a quick patch:

install( FILES pagersettings.kcfg DESTINATION ${KCFG_INSTALL_DIR} )

I rebuilt.

We now have pagersettings.kcfg in our packages.

I'll push both patches to GIT.

Darrell