trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2012

Re: [trinity-devel] bug #905 partial fix

From: Serghei Amelian <serghei@...>
Date: Sun, 1 Apr 2012 00:47:28 +0300
On Sunday 01 April 2012 00:38:55 Darrell Anderson wrote:
> > as reported in bug #905 tdebase cmake file does not check
> > for long long support breaking stuff like memory info module.
> >
> > To fix this I've added the following lines to
> > CMakeLists.txt:
> >
> > include( CheckTypeSize )
> >
> > CHECK_TYPE_SIZE("long long" LONG_LONG)
> >
> > and this line to config.h.cmake:
> >
> > #cmakedefine HAVE_LONG_LONG 1
> >
> > I'm not a cmake guru, just looked at the cmake wiki page, so
> > please double-check.
>
> Serghei or other cmake guru,
>
> Would you please validate this proposal?

Yes, it's correct. Just use small letters for macros (i.e. check_type_size) 
and add spaces between parentheses:

check_type_size( "long long" LONG_LONG )

Is not very important, but the cmake code will be uniform and easy readable.

-- 
Serghei