trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] Request patch testing please

From: "David C. Rankin" <drankinatty@...>
Date: Sat, 07 Apr 2012 23:53:06 -0500
On 04/07/2012 07:50 PM, Darrell Anderson wrote:
>>> I added a KControl check box control for the shutdown
>> feedback dialog. The one that says "Saving your settings" when logging out.
>>>
>>> The underlying support already existed. The check box
>> merely adds a direct way for users to show or disable the dialog box.
>>>
>>> The patch provides nominal temporary relief against bug
>> report 922: "When logging out with unsaved file, trinity does not ask to
>> save it," (http://bugs.pearsoncomputing.net/show_bug.cgi?id=922).
>> Currently the only solution to that bug is a work-around of disabling the
>> feedback dialog.
>>>
>>> The patch is available through bug report 681
>>> (http://bugs.pearsoncomputing.net/show_bug.cgi?id=681).
>>>
>>> Please test. Upon receiving a successful report I'll
>> push to GIT.
>>>
>>> Thanks for helping. :)
>>
> 
>> Tested in 3.5.13 - works well - signoff from me.
> 
> 
> Okay, thanks!
> 
> Before pushing to GIT I want to wait until Calvin finishes his patch for bug report 258. The check box added with this patch should be in the same group box in KControl with his patch.
> 
> Darrell
> 
Darrell,

  Just tried building with patch and I received a KCInit error on startup - no
desktop - (the main window was there, but no kicker, no desktop icons, etc..)
downgraded to unpatched filed and it worked great. I don't know which patch did
this, but we will need to investigate.

I have saved the xsession-errors file. It will take digesting, but I did notice
the new tdebase was nearly 9M larger than the last. Dunno why. I'll look more
tomorrow. Let's test some more before pushing.



-- 
David C. Rankin, J.D.,P.E.