Message: previous - next
Month: April 2012

Re: [trinity-devel] Please push - basket gcc47 patch [was Re: [trinity-devel] basket notepad failure (oh no!) - 'getuid' was not declared in this scope ??]

From: "Timothy Pearson" <kb9vqf@...>
Date: Tue, 10 Apr 2012 18:44:32 -0500
>> > From 'man getuid':
>> > #include <unistd.h>
>> > #include <sys/types.h>
>> Thank you my friend! Fixed in PKGBUILD with:
>>   cd ${srcdir}
>>   sed -i '/#include <kdebug.h>/s|$|\n#include
>> <unistd.h>\n#include
>> <sys/types.h>|' ${pkgname//tde-}/src/likeback.cpp
>>   Darrell, please verify this patch and have it
>> pushed.
>> md5sum: 3e7350c530d1324d1b4afbdcbe21fee0
> I can push, but somebody first please confirm for me, the C++ noob, that
> adding a header in the preprocessor includes does not impact backwards
> compatibility. That is, adding that include will not cause build failures
> with a gcc previous to 4.7
> Darrell

His patch is correct.  It is (nearly) impossible to break compilation by
including new base system headers that were included in previous gcc
versions via include chaining.

I really wonder why gcc can't leave well enough alone sometimes...we can't
be the only large project affected by this change...