trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] ALMOST (not reading .ssh/config) [was Re: [trinity-devel] sftp-kio - still fails in R14 - Any progress? (log captured - may help?)]

From: "Timothy Pearson" <kb9vqf@...>
Date: Tue, 24 Apr 2012 00:15:08 -0500
>> The part I don't get is that this worked at all in KDE
>> 3.5.10. Specifically this portion of the code:
>>
>>      else {
>>          struct servent *pse;
>>          if( (pse =
>> getservbyname("ssh", "tcp") ) == NULL )
>>              mPort =
>> 22;
>>          else
>>              mPort =
>> ntohs(pse->s_port);
>>      }
>>
>> looks like it should be completely removed!  This
>> duplicates the default port logic in ssh (bad), and also overrides any
>> ports set
>> via the ssh option file (even worse).
>>
>> I'd try removing that section of code to see if it resolves
>> the problem.
>
> Yes, but 3.5.10 was working during the OpenSSH <=5.5p1 days. Perhaps
> something changed >5.5p1 that causes that snippet to now fail?
>
> Darrell

The thing is, that snippet should never work in the first place.  Miracle
engineering, even if it worked in 3.5.10, usually fails once assumed
conditions change.

Tim