Message: previous - next
Month: April 2012

Re: [trinity-devel] sftp_kio - fix ssh port number read

From: "Timothy Pearson" <kb9vqf@...>
Date: Wed, 25 Apr 2012 12:16:20 -0500
> On 04/25/2012 02:05 AM, Timothy Pearson wrote:
>> Does this make sense?
>> Tim
> Yep,
>    I also see you reverted changes to ksshprocess.cpp as well.

???  Nothing should have been reverted. :-)

> It is
> amazing
> that the total fix only required removing 5 lines of code and adding:
>    mPort = -1;
>    How did you debug this? Did you just add kdDebug messages? Use some
> tool
> that allows you to set some sort of breakpoint in the code and then watch
> mPort? If you can pass those nuggets along, that will help Darrell and I
> come
> up to speed to better help with this type debugging.

Generally I read the code and insert debug printf() statements in the most
likely execution paths, near any chunks of code that I think are directly
handling the feature that has the bug in it.  These printf() statements
spew the status of any local variables that I think might be relevant to
the bug report; i.e. if there is a problem with port numbers, I look for
the sections of code that deal with port numbers, then print the port
numbers (at a minimum) at the beginning and end of those sections.