Message: previous - next
Month: April 2012

kmplayer patch

From: Darrell Anderson <humanreadable@...>
Date: Sat, 28 Apr 2012 10:08:56 -0700 (PDT)
A while ago David posted a build failure with kmplayer:

gstplayer.cpp:1009:5: error: C99 designator 'b' outside aggregate initializer

I don't know what the error means. David proposed a patch but nobody responded as to whether his patch was legitimate. Yesterday I tried to build kmplayer with gcc 4.7. I saw the same failure. I forgot about David's query. I looked around the web for clues to resolve the problem. I ran into this:

The patch description is exactly what David and I saw with the build failure. The patch was to the xineplayer.cpp module. Other than the difference between "XINE" and "XVIDEO" I figured the patch is just what the doctor ordered.

I massaged the patch for the gstplayer.cpp module and compiled. No failures and the package size is the same as non gcc 4.7 builds.

I tested the patch with a non gcc 4.7 build too.

I pushed the patch in GIT hash 5106117b.

Odd that the "C99 designator" problem was addressed in the xineplayer.cpp module yet the same exact code in gstplayer.cpp was not.

The patch does not include fixes for xine-libs. Because there remains a wide mix of xine-libs versions being used, at least for now, the original patch David proposed should have some preprocessor tests like we did with several other patches. That way the patch can be pushed to GIT and work for all versions of xine-libs.

I will try to do that. I searched the list archives but could not determine the exact version when the problems start. Which version of xine-libs causes the problems?