trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: April 2012

Re: [trinity-devel] Tim: tdegraphics POPPLER_016

From: "E. Liddell" <ejlddll@...>
Date: Sat, 28 Apr 2012 17:40:03 -0400
On Sat, 28 Apr 2012 18:51:13 +0200
/dev/ammo42 <mickeytintincolle@...> wrote:

> On Sat, 28 Apr 2012 11:07:05 -0500
> "David C. Rankin" <drankinatty@...> wrote:
> 
> > On 04/28/2012 08:27 AM, E. Liddell wrote:
> > > I poked the git server at freedesktop.org, where poppler resides,
> > > and found what appears to be the series of commits that removed QT3
> > > support (five on Jan. 16, 2011, plus an outlier about a month
> > > later).  Full diffs for these commits are stored, so depending on
> > > how much the codebase has changed in the past year, we may be able
> > > to just revert them.
> > 
> > That would be fantastic. I may still have all the older poppler
> > sources (somewhere). I we can just revert the changes in the current
> > code, that would be the best case, but if not, I have the last
> > freedesktop sources before the commits. I'll hunt them down if
> > needed, but I guess you GIT masters could just tell freedesktop to
> > spit the code out as it existed on 1/15/2011.
> > 
> > For my education -- "How do you do that?" Say I wanted to clone the
> > repository as it existed prior to the 1/16/2011 changes, what would
> > the git command look like?
> IIRC:
> 
> git clone <the repository>
> git checkout <the sha1 you want> .

Checkout information for the repository is given at
http://www.freedesktop.org/wiki/Infrastructure/git/Users .

For precise reference, the first QT3-killing commit appears to be

d82f98a274bfa008c218e265a080c4af7ce95131

and I think the commit immediately prior to it was 

301352e5585d4ab6e7b609b4ab79b4d8b8656092 

on Jan. 9.  The other QT3-killing commits were:

8dc9c693abb0033247a338d0f7d1f3f7a57c1a55
26da7a52d31eb677ab6399de2c07140aa272b35e
9a02856c2762e65b8f03e443e728e05e5a86f65b
76ab657dc81ed0af7d9f2efaca2e68d570063001 
728c022cdc1ea12aa54077d44276f9d7714930d4

I haven't read over the diffs in detail, but they seem to be
pure code erasure (many files were removed wholesale,
plus some switches in the build code).  We might just
be okay.