trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2012

Re: [trinity-devel] kipi-plugins patch (gcc 4.7 + libpng 1.5) [was Re: [trinity-devel] kipi-plugins FTBFS libpng 1.5 - fixed?]

From: /dev/ammo42 <mickeytintincolle@...>
Date: Fri, 4 May 2012 21:41:11 +0200
On Fri, 04 May 2012 14:00:39 -0500
"David C. Rankin" <drankinatty@...> wrote:

> On 05/04/2012 01:04 PM, David C. Rankin wrote:
> > On 05/04/2012 12:52 PM, Darrell Anderson wrote:
> >>>   I was thinking Darrell already had a patch for this
> >>> that allowed it to build w/o -fpermissive. This might just
> >>> be one of the -fpermissive issues that needs fixing. Anybody
> >>> know if a patch exists for this on gcc 4.7?
> >>
> >> There was no libpng patch for kipi-plugins. I'm curious why I
> >> never saw the same build failure. My log shows the warnings but
> >> not the failure.
> >>
> >> If a patch is needed, look at what we did for digikam:
> >>
> >> http://git.trinitydesktop.org/cgit/digikam/commit/?id=a94890345ef2caae35a72ed3a398b2984349bb2f
> >>
> >> Darrell
> >>
> > 
> > OK,
> > 
> >   This is one that does build with -fpermissive, but I was
> > eliminating those from the initial gcc47 build scripts. I'll have a
> > look. I'm certain it will be a simple fix -- the only question will
> > be -- how long it takes me to see it :)
> > 
> > 
> 
> Holy crap! It worked!
> 
>   Somebody who knows what they are doing, please sign off on this
> patch. If OK, then Darrell can go ahead and push. It builds fine with
> gcc 4.7 and libpng 1.5 -- and -- eliminates the '-fpermissive' build
> flag.

	(iCCP_data)ICCColorProfile.data()
is better replaced by
	static_cast<iCCP_data>(ICCColorProfile.data())
.
This also applies to the digikam patch.