trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: May 2012

Re: [trinity-devel] Commit c94de3af (GCC 4.7 fix) × KMail

From: Slávek Banko <slavek.banko@...>
Date: Sat, 26 May 2012 10:25:02 +0200
On Friday 25 of May 2012 22:03:59 François ANDRIOT wrote:
> Le 25/05/2012 16:39, Slávek Banko a écrit :
> > Darrell, David, François,
> >
> > I found that the first part of the commit c94de3af causes incorrect
> > computation of unread messages in KMail - in the tray icon. Every time
> > you switch to any folder, the number of unread messages is increased.
> >
> > I could easily revert that part, but I fear that it will return a problem
> > with gcc 4.7. You look at it? I do not know if a problem does not even
> > rename "it" in the second part - for KOrganizer.
> >
> > Slávek
>
> Hello,
> I think that you should keep the current patch (do not revert), then add
> the following:
>
> in file kmail/kmsystemtray.cpp on line 496, you should replace:
>      int diff = unread - it.data();
> with
>      int diff = unread - unread_it.data();
>
> I did not test it though, since I do not use kmail at all.
>
> François

You proposed patch solved the problem.
Fixed in GIT hash 40c435e5

Thank you
Slávek
--