trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: June 2012

Re: [trinity-devel] Bug 1063: glib upstream changes to header inclusion (with patch)

From: Darrell Anderson <humanreadable@...>
Date: Fri, 22 Jun 2012 14:46:45 -0700 (PDT)
> Upsteam glib changes have resulted in build failures giving the message:
> 
> #error "Only <glib.h> can be included directly."
> 
> We will want to add preprocessor directives on glib
> version as well to prevent borking builds on older glib. Also, what about a global fix
> with sed?

Which glib version started this latest round of silliness? We need to know that to add preprocessor directives.

I searched the source tree. Quite a few includes to glib.h. No changes necessary there. I did not perform any kind of complete or exhaustive search, but here is short list of what might need attention:

tdelibs/kglib/TGlibEventLoop.cpp:22: #include <glib-object.h>
tdebindings/xparts/mozilla/kmozilla.c:1: #include <glib-object.h>

libraries/kipi-plugins/kipi-plugins/ipodexport/plugin_ipodexport.cpp:15: #include <glib-object.h> //g_type_init

applications/koffice/filters/chalk/xcf/xcf/xcf-load.cc:24://#include <glib-object.h>
applications/koffice/filters/chalk/xcf/xcf/xcf-save.cc:24: #include <glib-object.h>
applications/koffice/filters/chalk/xcf/xcf/xcf-read.cc:23: #include <glib-object.h>
applications/koffice/filters/chalk/xcf/xcf/xcf-seek.cc:24: #include <glib-object.h>
applications/kmplayer/src/npplayer.c:33: #include <glib/gprintf.h>
applications/gtk-qt-engine/src/qt_theme_draw.c:6: #include <glib/glist.h>
applications/kdbusnotification/src/daemon/daemon.cpp:123: #include <glib-object.h>
applications/kdbusnotification/src/daemon/daemon.h:51: #include <glib-object.h>

Short list. :-)

Darrell