Message: previous - next
Month: June 2012

Re: [trinity-devel] Possible corrupt/unviewable images

From: Darrell Anderson <humanreadable@...>
Date: Fri, 29 Jun 2012 14:43:01 -0700 (PDT)
> I have no idea why that would have happened--I glanced at
> the XML, and as far as I could tell, there was nothing syntactically wrong with the
> file, it was just bloated with invisible text.
> (I do have bigger SVG files on hand, but none of them were
> intended to be icons...)

The identify command does not like the latest version either. I now suspect a bug with the imagemagick algorithms rather than the file. The file opens fine in gwenview and ksvg plugin viewer. Let's shrug about identify and move on.

> And was it something that he owned/had permission to use, or
> was kdesvn shipping with a bizarre hidden copyright violation for however many
> years?

I wondered about that too.

> > Now that I ask that, I see two other svgz images have
> that same Atkins diet text. Those also probably should get
> converted to gray bars or "greek" text:
> > 
> > hisc-action-tdesvndelete.svgz
> > hisc-action-tdesvnadd.svgz
> Please see if the attached file works as needed/intended.  If it does, I'll tackle the
> others.

The image looks great with the gray lines. :-)

I will recreate the pngs from that file and await your wondrous talents with the other two.

> So we either draw new ones or replace them with reasonably
> generic icons from among those already on-hand.  Or, if they're never
> actually displayed anywhere, delete them from the tree, just to be tidy.

I'm a tad embarrassed to say that the png files in tdesdk are not corrupt. Yet the short story is a good chuckle.

Yesterday I could not figure out why the files were corrupt all the way back to KDE 3.0 or something like that. Today I wondered whether I could use the same images from KDE4. The KDE4 images looked fine and they had similar file names as those in Trinity/KDE3.

As I stared at the directory file listing in konqueror, I (finally) noticed the file size of these allegedly corrupt png file: 171 B. Yes, bytes. Every single one, despite the file names implying different icon sizes. I'm a tad slow on some days so I decide to open one them with khexedit.

The allegedly corrupt png files are shells scripts. :-)

When I looked at the code in a text editor, I saw what was happening. The build process grabs copies of png images from elsewhere in the tdesdk sources to build image files. Those image files are not corrupt.

I feel a bit silly about that, but then again not --- why name a shell script with a png extension? Developers can be so freakin' off planet in some things they do.

Anyway, that reduces the original list of remaining corrupt images to the six files in pytdeextensions. All of them produce the same error message from identify: 'improper image header'. Looking at the file sizes indicates only two need to be replaced and the other four are copies of the same. Yes --- I checked the files --- they are not shell scripts. :-)