trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: August 2012

Re: [trinity-devel] 3.5.13-sru avahi-tqt (patch) - just need to pick commit and backport

From: Slávek Banko <slavek.banko@...>
Date: Tue, 14 Aug 2012 03:59:26 +0200
On Thursday 09 of August 2012 07:38:29 David C. Rankin wrote:
> On 08/08/2012 11:22 PM, David C. Rankin wrote:
> > Slavek,
> >
> >   avahi-tqt for 3.5.13-sru just needs the qt-watch.moc3 fix backported,
> > then it builds fine. The diff is attached. I can't find a commit in
> > http://git.trinitydesktop.org/cgit/avahi-tqt/ that matches, so this just
> > might need to be reviewed and signed off.
> >
> >   The reference for the fix is here:
> >
> > http://trinity-devel.pearsoncomputing.net/?0::6608
>
> I found it, it was commit 	8f7a6ec9f95f
>
> OK to backport to 3.5.13-sru

David,

I'm a little confused. The original code is:
  $(AM_V_GEN)$(MOC_QT3) moc $^ $@

Your proposed patch changes it to:
  $(AM_V_GEN)$(MOC_QT3) $^ $@

While commit 8f7a6ec9 changes the moc to tqmoc:
  $(AM_V_GEN)$(MOC_QT3) tqmoc $^ $@

Removing moc seems to me suspicious. Similarly, the replacement from moc to 
tqmoc makes me uncertainty.

Please have some more information?

Slavek
--