trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: July 2014

Re: [trinity-devel] Missing entries in Amarok tray icon menu

From: "Timothy Pearson" <kb9vqf@...>
Date: Sun, 13 Jul 2014 19:49:11 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224

> On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
>> I forgot to declare resizeEvent and showEvent as virtual void in
>> amarok/src/systray.h; I haven't yet tested if fixing this will repair
>> the
>> regression.  Aside from this slip-up I don't see anything in that commit
>> that should affect the menu options whatsoever.
>>
>> If you want to try adding the missing virtual keyword to those two
>> methods
>> please let me know if it fixes the problem.  Otherwise I'll try to track
>> this down tomorrow when I have more time.
>
> The following patch does not resolve the missing menu:
>
> diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h
> --- amarok/amarok/src/systray.h	2014-07-09 19:52:56.000000000 -0500
> +++ amarok.new/amarok/src/systray.h	2014-07-13 19:26:44.506064803 -0500
> @@ -30,8 +30,8 @@
>      virtual void engineTrackPositionChanged( long position, bool
> /*userSeek*/ );
>      // get notified of 'highlight' color change
>      virtual void paletteChange( const TQPalette & oldPalette );
> -    void resizeEvent ( TQResizeEvent * );
> -    void showEvent ( TQShowEvent * );
> +    virtual void resizeEvent ( TQResizeEvent * );
> +    virtual void showEvent ( TQShowEvent * );
>
>  private:
>      bool event( TQEvent* );
>
> Darrell

OK, thanks for testing.

Slavek, can you see any way that this commit could have affected the tray
icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf5234cb8327b2bfa1e0a025

Thanks!

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iFYEARELAAYFAlPDKQcACgkQLaxZSoRZrGE3PwDaA/B9C81xy7Yi/y/7g0dmYufP
EedM+MCcJLJ6vQDfQkoCI1kNsKYVUr35r02i0HV9iXUWAC1bSJBxRQ==
=OKzL
-----END PGP SIGNATURE-----