On 10 March 2012 14:44, Darrell Anderson <humanreadable@...> wrote: >> Unfortunately, (Embarassingly?) I do not have a running GIT >> system. Now that David Rankin has finished successfully building >> arch and TDE I will spend some time getting a git system running on my >> computer. The problem is that I use TDE for my work - so I don't want >> to break it :p > > I understand. I'm fortunate to have a nice desktop machine. I set up virtual machines to test my GIT packaging. That way I don't mess my production desktop. I also have a separate partition on the hard drive that has TDE installed. I have to reboot, of course, but when I am satisfied with my VM testing I then reboot, reinstall the latest packages, and then test. For example, I can't test tuner card issues in my VM (Kaffeine). I have to have a real hardware desktop for that. But overall, the VMs save me gobs of time. > >> Luckily this patch is just implementing a small >> configuration option related to bug 251. Should be easy enough to use my 3.5.13 >> sources and not break anything. > > If you resolve bug report 251 then I'll buy you a round of virtual beers. :) Let me know your progress --- I'll be the first in line to test! > >> > To all: after building from the latest GIT you notice >> other branding issues, please post a note to the list and >> I'll try to fix the problem ASAP. >> >> have you tried to just grep for all strings related to KDE? >> I found a regular grep doesn't work well, but doing a pipe helps >> >> grep "i18n" * -r | grep "KDE" >> >> this will show all the KDE's in any string recursively. > > More or less, yes. However, I am not a skilled C++ hacker. Someday, maybe, but not today. :) I also don't know the big picture of how all the various files interrelate. I can't blindly search and replace strings. I tried that a few times and humbled myself by how much things broke. :) Not all strings that SEEM to need replacing should be replaced. I have to be careful because although certain text strings get replaced, I can't replace strings that actually are part of the app name or code base. For example, I can replace user related text strings about "K Menu" -> to "TDE Menu" but kmenu itself remains named the same. > > Thus a basic search still requires manually looking at code and context before replacing text. > > Further complicating the topic is translations. With many *.desktop files I can replace singular characters like KDE -> TDE and presume I am not doing any serious damage. Yet I can't fix only the English text strings in [Comments] because I can't translate those changes in the other languages. I have to leave those text strings untouched regardless of how much I want to change them. > > I have the same challenge with updating the help files. Except for minor entity fixes, I can't touch the tde-i18n versions. I don't know how we'll ever fix those files. At times I am inclined to delete them all. That would cause the system to use the default English versions, but that likely would upset TDE users who do not use English. > > So in summary, these branding issues are not all proverbial walks on the beach. My basic approach now is to slow down and only fix what I actually see and not try to guess what could be fixed. :) > > Darrell > Uploading a patch that fixes the problem :)