trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: November 2012

Re: [trinity-devel] cmake bug with 64-bit?

From: Serghei Amelian <serghei@...>
Date: Sun, 11 Nov 2012 19:46:32 +0200
On Sunday 11 November 2012 19:31:24 Fat-Zer wrote:
> 2012/11/11 Serghei Amelian <serghei@...>
>
> > Do not override/pollute CMAKE_REQUIRED_INCLUDES, you can fall into
> > another strange and hard to hunt bugs.
> >
> > Correct way:
> >
> > tde_save_and_set( CMAKE_REQUIRED_INCLUDES ${FRIBIDI_INCLUDE_DIRS} )
> > check_include_file( fribidi/fribidi-types.h FRIBIDI_NEW_FILENAME )
> > tde_restore( CMAKE_REQUIRED_INCLUDES  )
>
> It's a good practice, but here it is no difference...
> CMAKE_REQUIRED_INCLUDES remains set only until end of file and there is no
> other compilations...

Well, is bad idea to think that "in this particular case will working". The 
particular cases can be changed, new checks can be added, etc.

-- 
Serghei