trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2013

Re: [trinity-devel] Adverse renaming

From: "Timothy Pearson" <kb9vqf@...>
Date: Sat, 2 Feb 2013 00:59:15 -0600
> Tim,
>
> looking at the recent changes in the tde-packaging I see several varieties
> of
> adverse renaming. For example:
>
> -debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.la
> -debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.so
> -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.la
> -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.so
> +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.la
> +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.so
> +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.la
> +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.so
>
> ...and many other chalk* => chaltde*
>
> -debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tasklist.ktf
> -debian/tmp/opt/trinity/share/apps/kplato/reports/tasklist.desktop
> +debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tastdelist.ktf
> +debian/tmp/opt/trinity/share/apps/kplato/reports/tastdelist.desktop
>
> -debian/tmp/opt/trinity/include/tdeparts/dockmainwindow.h
> +debian/tmp/opt/trinity/include/tdeparts/doctdemainwindow.h
>
> -debian/tmp/opt/trinity/include/tdetexteditor/blockselectioninterface.h
> +debian/tmp/opt/trinity/include/tdetexteditor/bloctdeselectioninterface.h
>
> -debian/tmp/opt/trinity/include/kopete/ui/addressbookselectordialog.h
> -debian/tmp/opt/trinity/include/kopete/ui/addressbookselectorwidget.h
> +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectordialog.h
> +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectorwidget.h
>
> In addition, some partial repairs but also other adverse renaming:
>
> ---- kiosktool/tdeiosktool/tdeioskrun.cpp   2005-04-25 10:46:33.000000000
> +0100
> -+++ kiosktool/tdeiosktool/tdeioskrun.cpp     2007-07-20
> 16:56:07.000000000
> +0100
> +--- kiosktool/kiosktool/tdeioskrun.cpp     2005-04-25 10:46:33.000000000
> +0100
> ++++ kiosktool/kiosktool/tdeioskrun.cpp     2007-07-20 16:56:07.000000000
> +0100
>
> -+  return "Error in Kiosktool Kubuntu modifications";
> ++  return "Error in Kiostdetool Kubuntu modifications";
>
> These are just some examples, which I happened to notice. I'm afraid that
> it
> will take a lot of eyes, to reveal all the adverse renaming. I think it is
> right to make this great renaming before release final R14, but I believe
> that the recently proposed date for release final R14 need to be
> revisited.
>
> Slavek
> --

Yes, the R14 release will probably need to be pushed back.  This renaming
effort will end up being a multi-stage process with pauses to search for
problems such as the ones you noticed already.

So if I have this correct, you have noticed the following invalid strings:
chaltde
tastdelist
doctdemain
loctdeselect
bootdeselect
tdeiosk
Kiostde

I have already noticed and corrected several of these, but you also
spotted some that I did not see at first.

Most of the problems are caused by the fact that the KDE developers
prefixed most libraries and header file names, not to mention application
names, with a single letter 'k'.  In hindsight, this practice makes any
renaming projects much more difficult than if a multiple character unique
prefix such as 'kde' was used instead, not to mention increasing the
chances of collision with existing libraries outside of KDE (e.g. a
hypothetical Kerberos interface library might try to add a 'k' prefix to
its class names through the same logic).  I am consistently replacing all
K class prefixes with TDE to mitigate this problem, however as you noticed
this process is quite error prone.

Tim