Message: previous - next
Month: May 2013

Re: [trinity-devel] kio_imap4 fix

From: François Andriot <francois.andriot@...>
Date: Tue, 28 May 2013 19:24:00 +0200
Le 28/05/2013 17:53, Serghei Amelian a �crit :
> On Tuesday 28 May 2013 18:31:37 Sl�vek Banko wrote:
> [...]
>> I use kmail with IMAP4 on 64bit system for a long time and I did not
>> notice endless loops before using your patch, even then.
>> Several problems was fixed by Fran�ois in earlier patches:
>> + 786fea2 Fix another endless loop in imapparser (Bug 1235)
>> + 590161f Fix more SEGV in imapparser (Bug 1235)
>> + 9b43d6e Fix segfault in IMAP folder parsing
>> + b0c92b3 Fix long response time on large IMAP folders (Bug 1009)
>> + aa2af25 Fix IMAP hang on auth failure (Bug 1007)
>> Slavek
> I guess that the endless-loop on 64 bit systems is fixed by one of Fran�ois'
> patches.
> My patch fixed this issue as a side effect, I discovered that kio_imap4 read
> lines of stream wrongly (i.e. read one line and half, instead one line at
> once) and I tried to address this.

I confirm that my own patches were written to solve 2 frequent issues 
that I had seen :
- Segmentation fault while parsing imap stream, causing kmail crash;
- Endless loop while parsing imag stream, causing 100% CPU and kmail hang.
(I'm on 64 bit BTW.)

Now kmail does not crash anymore, but I still have issues with imap parsing:
when opening a big imap folder containing "bad" mails (chinese spam, 
badly encoded ...), kmail often shows them as "unknown" and "unread" 
This is because the imap parser fails.
So when I open my spam folder containing lots of badly-encoded chinese 
spam, I see lots of "unknown/unread" messages, but this is wrong. They 
are correctly displayed in Thunderbird.

Now, the kio_imap4 fix from Serghei seems to fixes the parsing issues: 
now I can browse all my folders correctly in kmail.
So, I think we should push this patch in Without it, I 
consider kmail as being unusable with imap (at least: I would not 
recommend using kmail without this patch).