On Saturday 07 of September 2013 08:20:12 Darrell Anderson wrote:
> * tdesu: WARNING: unknown super user command

Test the super user command is a one tdelibs/tdesu/su.cpp a second time in 
tdebase/tdesu/sudlg.spp. Valid is considered "sudo" or "su".

For tdebase is in tdebase/tdesu/CMakeLists.txt defined:

if( WITH_SUDO_TDESU_BACKEND )
  set( DEFAULT_SUPER_USER_COMMAND sudo CACHE INTERNAL "" FORCE )
else()
  set( DEFAULT_SUPER_USER_COMMAND su CACHE INTERNAL "" FORCE )
endif()

For tdelibs is in tdelibs/CMakeLists.txt defined:

# FIXME for unknown reason cmake cannot find su
#find_program( __PATH_SU su )
set( __PATH_SU "/bin/su" )

if( __PATH_SU )
  set( DEFAULT_SUPER_USER_COMMAND ${__PATH_SU} )
else( __PATH_SU )
  message( STATUS "WARNING: su was not found" )
endif( __PATH_SU )

# FIXME for unknown reason cmake cannot find sudo
# find_program( __PATH_SUDO "sudo" )
set( __PATH_SUDO "/usr/bin/sudo" )
if( WITH_SUDO_TDESU_BACKEND )
  if( __PATH_SUDO )
    set( DEFAULT_SUPER_USER_COMMAND ${__PATH_SUDO} )
  else( __PATH_SUDO )
    message( FATAL_ERROR "sudo was chosen as tdesu backend, but was not found 
in path." )
  endif( __PATH_SUDO )
endif( WITH_SUDO_TDESU_BACKEND )

In neither case does not test for the presence sudo. And in tdelibs instead of 
setting DEFAULT_SUPER_USER_COMMAND to su or sudo is used full path to binary, 
which is incorrect.

Proposed patches attached.

Slavek
-- 

Attachments:

• tdebase-tdesu-backend-check.diff (text/x-diff, 0.6kb)
• tdelibs-tdesu-backend-check.diff (text/x-diff, 1.4kb)