trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: October 2013

Re: [trinity-devel] Commit cced03e1 2013-10-17

From: Slávek Banko <slavek.banko@...>
Date: Wed, 23 Oct 2013 23:46:20 +0200
On Wednesday 23 of October 2013 23:28:58 Darrell Anderson wrote:
> Um, yes, I think so. I presumed something similar was needed but I
> wanted one of the experts to say as much. :-)
>
> * Are you going to push the patch?
>
> * How do we test the binaries compiled correctly when
> WITH_TDEICONLOADER_DEBUG=true? Backtraces?
>
> * Is this an option normally left as false and changed to true only
> when a developer asks for that change to help debug related
> problems?

I prepared a patch right now - I myself have not tested it yet :)

However, yes, the idea is that by default will be WITH_TDEICONLOADER_DEBUG 
turned OFF. And if anyone will wish to debug TDEIconLoader class, then need 
to rebuild tdelibs with option WITH_TDEICONLOADER_DEBUG turned ON.

Slavek