trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: February 2014

Re: [trinity-devel] cmake conversion audit

From: "David C. Rankin" <drankinatty@...>
Date: Wed, 12 Feb 2014 11:34:43 -0600
On 02/11/2014 05:45 PM, Darrell Anderson wrote:
> Here is a preliminary list of modules converted to cmake that 
> contain directories with a Makefile.am but no corresponding 
> CMakeLists.txt. The list offers no conclusions. Just a list. Which 
> items are legitimate remains to be investigated.
> 
> amarok/amarok/src/engine/helix
> amarok/amarok/src/engine/helix/config
> amarok/amarok/src/engine/helix/helix-sp
> amarok/amarok/src/engine/kdemm

Yes,

  The subdirs are going to be the tricky ones. Many times if their parent has
both a CMakeLists.txt and Makefile.am, then we are good. In that case we must
verify the parent Makefile.am includes something like 'SUBDIRS = $(AUTODIRS)'
that automatically includes all subs or in cases like Amarok, the parent
Makefile is option controlled on whether the subdirs are built:

amarok/amarok/src/engine/Makefile.am

#if with_gst10
#    GST10_ENGINE_SUBDIR = gst10
#endif

if with_nmm
    NMM_ENGINE_SUBDIR = nmm
endif

if with_xine
    XINE_ENGINE_SUBDIR = xine
endif

if with_helix
    HELIX_ENGINE_SUBDIR = helix
endif

if with_yauap
    YAUAP_ENGINE_SUBDIR = yauap
endif

SUBDIRS = . \
    void \
    $(XINE_ENGINE_SUBDIR) \
    $(NMM_ENGINE_SUBDIR) \
    $(HELIX_ENGINE_SUBDIR) \
    $(YAUAP_ENGINE_SUBDIR)

  I haven't had a chance to dig further, it will likely be tomorrow or Friday.

-- 
David C. Rankin, J.D.,P.E.