trinity-devel@lists.pearsoncomputing.net

Message: previous - next
Month: March 2014

Re: [trinity-devel] Finish renaming tdevelop components

From: Slávek Banko <slavek.banko@...>
Date: Sat, 1 Mar 2014 18:49:03 +0100
On Friday 28 of February 2014 03:44:51 Darrell wrote:
> Here is a link to a 13 MB patch that finishes renaming tdevelop components.
>
> http://humanreadable.nfshost.com/misc/tdevelop-kdev-tdev-rename.diff
>
> There are no build failures or errors or warnings. I don't know how to use
> tdevelop but my modest tests indicates the patch is stable. You folks who
> use tdevelop can test more thoroughly and update the patch as needed.
>
> Darrell
>

I am just beginning and I noticed two problems:

__1__

-mimedir = $(kde_mimedir)/application
+mimedir = $(tde_mimedir)/application

Variable kde_mimedir is defined in the common 'admin' module. Change to 
tde_mimedir would mean a change first in common 'admin' module and 
subsequently in all other modules.

__2__

diff -urNa tdevelop/admin/am_edit tdevelop.new/admin/am_edit
--- tdevelop/admin/am_edit	2013-12-23 12:30:03.000000000 -0600
+++ tdevelop.new/admin/am_edit	2014-02-27 16:11:26.838531714 -0600
@@ -432,7 +432,7 @@
     # some strange people like to do a install-exec, and expect that also
     # all modules are installed.  automake doesn't know this, so we need to 
move
     # this here from install-data to install-exec.
-    if ($MakefileData =~ m/\nkde_module_LTLIBRARIES\s*=/) {
+    if ($MakefileData =~ m/\ntde_module_LTLIBRARIES\s*=/) {
 #      $target_adds{"install-exec-am"} .= "install-kde_moduleLTLIBRARIES ";
 #      don't use $target_adds here because we need to append the dependency, 
not
 #      prepend it. Fixes #44342 , when a module depends on a lib in the same 
dir

Here patch blatantly making a change for the common 'admin' module.

-- 
Slavek