-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224 > Le 18/08/2014 23:08, Timothy Pearson a �crit : >> >> OK, it looks like I have some repairing to do. Can you post a simple >> set >> of instructions for the tqt3 build process (assuming there is more to it >> than just ./configure, make)? A link to the installer of the version of >> OpenBSD you were using would also be helpful. >> >> Thanks! >> >> Tim >> > > Finally, I've managed to build TQT3 on openbsd 5.5 using the attached > packaging files. > This stuff is expected to go to /usr/ports/x11/trinity/dependencies/tqt3 > directory. > I've not built tdelibs R14 yet so I'm not sure it works better than > 3.5.13.2 . > > Please review the contained patches and give your opinion. > > Fran�ois A few questions/comments... 1.) patch-mkspecs_openbsd-g++_qmake_conf looks like a bit of a hack. Is there a better way to do this so that the chages are only applied when TQt3 is built on a BSD (non-Linux) platform? 2.) What is the point of patch-plugins_src_sqldrivers_sqldrivers_pro? 3.) patch-qmake_generators_unix_unixmake2_cpp largely looks OK for merge, with the potential exception of line 385. Why was this added? I can check for Linux compatibility if it is needed for proper BSD compilation. 4.) patch-qmake_generators_unix_unixmake_cpp looks OK for merge. 5.) We will not be merging patch-src_kernel_ntqstyle.h, but if you could please post the build log without that applied I can fix the real problem in GIT. 6.) patch-src_tools_qmutex_unix_cpp looks OK for merge. 7.) patch-src_tools_qstring.cpp looks OK for merge, but we do need to document somewhere that the secured memory feature of TQString is not available except on Linux (unless BSD has a similar feature to keep a specific memory segment out of the swap file). 8.) patch-src_widgets_qlineedit_cpp looks OK for merge, but see previous note in 7.) on documentation and/or fixing the issue. Overall good work! The main thing I want to see at this point is autodetection of BSD so that we don't have to manually apply the first patch for all the others to work. Thanks! Tim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iFYEARELAAYFAlP1/pAACgkQLaxZSoRZrGGhrwDbB5T256E03dPa8LPQs0MtWEcr 39EMfIGuy2/rdwDgppFrWa5pxtbhjA0qPbKCxU4jZjlofRL+XQ5LIw== =vXgl -----END PGP SIGNATURE-----